The Witness: Allow specifying custom trap weights #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
NewSoupVi
added
the
is: enhancement
Co-authored-by: Exempt-Medic <[email protected]>
Exempt-Medic
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Code LGTM. Compared generations with and without the changes. Did some test generations to check if weights worked properly and checked that improper formatting lead to (useful) errors. Booted up a game and received a trap item just in case that somehow mattered
NewSoupVi
added
waiting-on: core-review
Berserker66
approved these changes
Feb 29, 2024
github-actions
bot
removed
the
waiting-on: core-review
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
* Trap weights * Slightly change the way the option works * Wording one more time * Non optional to bring in line with Ixrec's implementation * Be clear that it's not an absolute amount, but a weight * E x c l a m a t i o n p o i n t * Update worlds/witness/items.py Co-authored-by: Exempt-Medic <[email protected]> * Wait I can just do this now lol --------- Co-authored-by: Exempt-Medic <[email protected]>
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
* Trap weights * Slightly change the way the option works * Wording one more time * Non optional to bring in line with Ixrec's implementation * Be clear that it's not an absolute amount, but a weight * E x c l a m a t i o n p o i n t * Update worlds/witness/items.py Co-authored-by: Exempt-Medic <[email protected]> * Wait I can just do this now lol --------- Co-authored-by: Exempt-Medic <[email protected]>
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
* Trap weights * Slightly change the way the option works * Wording one more time * Non optional to bring in line with Ixrec's implementation * Be clear that it's not an absolute amount, but a weight * E x c l a m a t i o n p o i n t * Update worlds/witness/items.py Co-authored-by: Exempt-Medic <[email protected]> * Wait I can just do this now lol --------- Co-authored-by: Exempt-Medic <[email protected]>
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
* Trap weights * Slightly change the way the option works * Wording one more time * Non optional to bring in line with Ixrec's implementation * Be clear that it's not an absolute amount, but a weight * E x c l a m a t i o n p o i n t * Update worlds/witness/items.py Co-authored-by: Exempt-Medic <[email protected]> * Wait I can just do this now lol --------- Co-authored-by: Exempt-Medic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:)
Decided to make this an options dict, I really don't like having one option per trap, it's just so much bloat
Tested:
Just genned & debugged some stuff
This did also necessitate moving the initialisation of the Static classes to their respective files.
At some point soon, I should just change these to be submodules and get rid of the notion of the "static class"
Definitely got too many refactoring PRs open right now to wanna do sth that invasive though