Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lufia2ac: ability to swap party members mid-run and option to gain EXP while inactive #2800

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

el-u
Copy link
Collaborator

@el-u el-u commented Feb 7, 2024

What is this fixing or adding?

In AP, the option shuffle_party_members can be used to turn party members into a multiworld unlockable. Custom items were added to the game that enable the player to add newly unlocked members to the party even while a cave dive is already in progress (as opposed to the vanilla behavior where all characters are available form the start, but you can only change your party in town).

Until now, there were 2 shortcomings associated with this feature:

  • There was no way to remove party members during a run. So if you used whatever characters you unlocked first to fully fill up your party, but then were later sent a more desirable character, the only way to get them in would be to abort the current run and go back to town to reform your party.
    With this PR, the custom item that adds a character to the party can now simply be used again to remove them, allowing players to swap any unlocked characters in and out at will.
  • Only characters in the current party could gain EXP. So if you added a newly unlocked character when you had progressed deep into the cave already, they would join at your chosen party_starting_level, potentially being far behind in power compared to any characters that had been present all the way from the start of the run.
    With this PR, the new option inactive_exp_gain allows characters to gain EXP even while they are not present in the current party. Players can choose between full, half, or no EXP gain for the inactive characters.

How was this tested?

Ludwig tested it.

If this makes graphical changes, please attach screenshots.

Tia_levels_up

@ScipioWright ScipioWright added is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Feb 7, 2024
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes in a run and everything worked well / as expected. The options and docs changes look fine to me, but I can't say anything about the specifics of the ASM changes

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 5, 2024
@Berserker66 Berserker66 merged commit 14437d6 into ArchipelagoMW:main Apr 8, 2024
12 checks passed
@el-u el-u deleted the lufia2ac-main branch April 9, 2024 06:16
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants