BizHawkClient: Use callbacks in connector script instead of else/ifs #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
added
the
is: refactor/cleanup
PoryGone
added
the
waiting-on: peer-review
agilbert1412
approved these changes
Feb 13, 2024
ScipioWright
added
waiting-on: core-review
Berserker66
approved these changes
Feb 16, 2024
github-actions
bot
removed
the
waiting-on: core-review
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Addresses #2763. I suppose it's probably technically a speed improvement and better follows typical lua practices. But otherwise shouldn't change functionality. Just cleanup.
Also moves the debug variable up to the top of the file. for easier access.
How was this tested?
Ran Emerald for a couple minutes. Triggered an "unknown command" error to make sure it still got sent to the client.