Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebHost: provide None password to URI so it doesn't get stripped #2777

Merged
merged 1 commit into from
Feb 5, 2024
Merged

WebHost: provide None password to URI so it doesn't get stripped #2777

merged 1 commit into from
Feb 5, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Should make Firefox able to connect again

How was this tested?

Not on Firefox yet.

If this makes graphical changes, please attach screenshots.

ThePhar
ThePhar approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@ThePhar ThePhar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Firefox and confirmed issue resolved. Only thing to note is if a room has a password set, it will display "Invalid password" before asking for the actual password. But no actual functionality is broken.

image

@ThePhar ThePhar added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. affects: webhost Issues/PRs that touch webhost and may need additional validation. labels Jan 29, 2024
@LegendaryLinux LegendaryLinux merged commit 4032cfb into main Feb 5, 2024
14 checks passed
@Berserker66 Berserker66 deleted the webhost_workaround_uri branch February 5, 2024 23:26
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@Berserker66 @Jouramie
WebHost: provide None password to URI so it doesn't get stripped (Arc…
b9fb61d 
…hipelagoMW#2777)
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@Berserker66 @TheLX5
WebHost: provide None password to URI so it doesn't get stripped (Arc…
a514728 
…hipelagoMW#2777)
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@Berserker66 @TheLX5
WebHost: provide None password to URI so it doesn't get stripped (Arc…
417e5c1 
…hipelagoMW#2777)
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@Berserker66 @EmilyV99
WebHost: provide None password to URI so it doesn't get stripped (Arc…
0077e44 
…hipelagoMW#2777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePhar ThePhar ThePhar approved these changes

Assignees
No one assigned
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Berserker66 @ThePhar @LegendaryLinux