-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KH2: Fix empty location groups #2757
Conversation
Co-authored-by: Aaron Wagener <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the typing of location_groups is incorrect and i don't really understand why it's on a separate line, but those are out of scope for this PR so the changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Aaron Wagener <[email protected]>
Co-authored-by: Aaron Wagener <[email protected]>
Co-authored-by: Aaron Wagener <[email protected]>
Co-authored-by: Aaron Wagener <[email protected]>
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
removes the empty location groups from the data package
How was this tested?
genned a seed and ran unittests
If this makes graphical changes, please attach screenshots.