Shivers: Fixes issue with office elevator rule logic. #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes this looks correct. |
ScipioWright
added
the
is: bug/fix
Berserker66
approved these changes
Jan 11, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…2690) Office elevator logic was written as can reach Underground Tunnels OR can reach Office AND have Key for Office Elevator Meaning that key for office elevator was not required if Underground Tunnels could be reached when it should be. Changed to (can reach Underground Tunnels OR can reach Office) AND have Key for Office Elevator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Office elevator logic was written as
can reach Underground Tunnels OR can reach Office AND have Key for Office ElevatorMeaning that key for office elevator was not required if Underground Tunnels could be reached when it should be.
Changed to
(can reach Underground Tunnels OR can reach Office) AND have Key for Office ElevatorHow was this tested?
Wasn't, simple issue and same as 2657
Until this fix is out either
normalshould not be used for lobby access or elevators stay solved should not be used.