Hollow Knight: Fix fragile/unbreakable charm variants counting as 2 distinct charms in logic. #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deletes CHARM of the 3 unbreakable charms, adds 0.5 CHARM to Queen_fragment, King_Fragment and Void_heart
BadMagic100
added
the
is: bug/fix
ThePhar
changed the title
BadMagic100
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Looks fine to me
As discussed in discord, I'm not a huge fan of the way fragiles/unbreakables were fixed but given any change here will be made obsolete when the new extractor runs I think it's an acceptable hotfix as a proper fix (similar to how split cloak is dealt with) is probably unnecessarily involved.
Berserker66
approved these changes
Jan 11, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…istinct charms in logic (ArchipelagoMW#2683) Deletes CHARM of the 3 unbreakable charms, adds 0.5 CHARM to Queen_fragment, King_Fragment and Void_heart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with charm costs
What is this fixing or adding?
Fixes unbreakable charms counting double towards charm cost in shops in logic, creating unbeatable seeds. Also fixes kingsoul/voidheart not counting towards this total.
How was this tested?
Generated multiple seeds from source locally and went trough the playtrough in the spoiler log.
A seed with lurien plando'd onto salubra with 40 charms is beatable. If a regular charm is also plando'd onto salubra with 40 charms it says that the game is unbeatable (as it should), but with a white fragment it generates properly.
If this makes graphical changes, please attach screenshots.