Zillion: remove old option access from item link validation #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a little bit a cleaning in other stuff nearby
alwaysintreble
added
the
is: refactor/cleanup
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…agoMW#2673) * Zillion: remove old option access from item link validation and a little bit a cleaning in other stuff nearby * one option access missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
This removes the old option access from item link validation.
(Item links are the most affected part of the code.)
and a little bit of cleaning in other stuff nearby
I think that's the last of the old option access in Zillion.
How was this tested?
generated a 3-Zillion game with item links and played it with myself, making sure item links worked as expected