WebHost: Fix 500 Server errors relating to player/multi trackers. #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
added
is: bug/fix
|
instead of the ifs in the template, maybe it's worth doing the same thing CommonClient does? Check out uses of "Utils.KeyedDefaultDict". |
Does that work in Jinja? I'll take a look here in a moment. |
|
Sure enough.
|
Berserker66
approved these changes
Jan 4, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…chipelagoMW#2664) * WebHost: Fix player tracker issue with items missing from data package. Reported in https://discord.com/channels/731205301247803413/1192202112172576819 * WebHost: Fix multi-tracker error when item links are present. Reported in https://discord.com/channels/731205301247803413/1192104719959724062 * Use Utils.KeyedDefaultDict instead of checking for key * formatted revert * import tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes multiple 500 errors when item links are present or if items/locations do not exist in data package.
How was this tested?
Ran webhost with a room with item links and a room with a broken data package and confirmed everything was displaying correctly again.
If this makes graphical changes, please attach screenshots.