SM: strict rom validation fix #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table) This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client - end game get from ROM in client - send self item to server - add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
… and done some cleaning
…er's" This reverts commit fb3ca18.
- fixed seeded generation - fixed broken logic when more than one SM world - added missing rules for inter-area transitions - added basic patch presence for logic - added DoorManager init call to reflect present patches for logic - moved CollectionState addition out of BaseClasses into SM world - added condition to apply progitempool presorting only if SM world is present - set Bosses item id to None to prevent them going into multidata - now use get_game_players
…VariaRandomizer's rules, items, locations and accessPoint (as regions)
…se (fills ROM item table) This is dependant on modifications done to sm_randomizer_rom project
- player name inject in ROM and get in client - end game get from ROM in client - send self item to server - add player names table in ROM
…ition of an array of it (required to generation more than one SM world, which is still fails but is better)
… and done some cleaning
…starting with "SM" changing the tag would break backward compatibility
|
For visibility: @Rosalie-A @PoryGone |
|
Seems like a reasonable solution for now. Some discussion was had for a more extensible solution to this for the long term, but this is sufficient in the short term. |
|
Seems fine to me. It's a stopgap, but doesn't make a longer term solution
harder, so seems win/win.
…On Tue, Dec 26, 2023, 14:19 PoryGone ***@***.***> wrote:
Seems like a reasonable solution for now. Some discussion was had for a
more extensible solution to this for the long term, but this is sufficient
in the short term.
—
Reply to this email directly, view it on GitHub
<#2632 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOUHNIXSPAIB5HUBFK7YIBTYLMPL5AVCNFSM6AAAAABBDQO5GKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG4ZDSMJRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Berserker66
approved these changes
Dec 28, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
added a more robust ROM tag validation to free oher games to use tag starting with "SM" followed by another letter (SMW, SMZ3, SMRPG, SMMR,...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
added a more robust ROM tag validation to free oher games to use tag starting with "SM" followed by another letter (SMW, SMZ3, SMRPG, SMMR,...)
How was this tested?
I tested it with MapRando first released APWorld that was using "SMMR" as tag.
This caused issues for more than one world maintainer reported here:
https://discord.com/channels/731205301247803413/1156395911874875473/1188282338803732572
https://discord.com/channels/731205301247803413/1156395911874875473/1156577720222892083