[TLOZ] Fix bug with item drops in non-expanded item pool #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making it no longer possible to strand items in a take any cave permanently in edge cases
# Conflicts: # Launcher.py # host.yaml
remove read_rom as it no longer exists.
turns out I need to actually update that line with the new util function instead of just ripping out the one that doesn't exist anymore. using something labeled to be used for snes on a nes rom feels weird but if it works, it works.
Fixing an extra paranthesis
…/Archipelago into The-Legend-of-Zelda-AP
Off by one error with sixteen character names.
t3hf1gm3nt
added
the
is: bug/fix
t3hf1gm3nt
approved these changes
Dec 24, 2023
There was a problem hiding this comment.
Ran a test gen and checked the problem locations in game. They are now the correct vanilla items instead of the "phantom bomb" we were getting
Also picked up a few other items along the way, both rando'd and non-rando'd. all items seemed to be what they were supposed to be.
Berserker66
approved these changes
Dec 28, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…MW#2623) There was a bug in non-expanded item pool where due to the base patch changes to accommodate more items in dungeons, some items were transformed into glitch items that removed bombs (this also happened in expanded item pool, but the item placement would overwrite the results of this bug so it didn't appear as frequently). Being a Zelda game, losing bombs is bad. This PR fixes the base patch process to avoid this bug, by properly carrying the value of a variable through a procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please format your title with what portion of the project this pull request is
targeting and what it's changing.
ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"
What is this fixing or adding?
There was a bug in non-expanded item pool where due to the base patch changes to accommodate more items in dungeons, some items were transformed into glitch items that removed bombs (this also happened in expanded item pool, but the item placement would overwrite the results of this bug so it didn't appear as frequently). Being a Zelda game, losing bombs is bad. This PR fixes the base patch process to avoid this bug, by properly carrying the value of a variable through a procedure.
How was this tested?
Ran a couple of generations, checked the rom data for that location and saw that the byte for the item was getting changed properly, which was not the case beforehand.
If this makes graphical changes, please attach screenshots.
None