The Witness: Allow Mountain Lasers to go up to 11 instead of 7. #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewSoupVi
added
the
is: enhancement
ReverM
suggested changes
Dec 20, 2023
ReverM
reviewed
Dec 25, 2023
Exempt-Medic
approved these changes
Jan 1, 2024
NewSoupVi
force-pushed
the
11_mountain_lasers
branch
from
ec008b8 to
4f3e5e5
Compare
|
(That force push is me making a change, then reverting it via reset -> force push. Nothing has actually changed) |
Berserker66
approved these changes
Jan 16, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So up until now, it has been forbidden to put mountain_lasers at a number greater than 7.
This is because the solution is on the bottom of the box, which looks like this:
It is required to first open the hatch below to be able to step onto the staircase under the box.
However, I have managed to rotate the mountaintop box in such a way that makes this no longer a requirement:
There is some light clipping, but it looks genuinely ok if you don't look for problems, I think.
So, I can now allow mountain_lasers to be higher than 7.
Important note on logic
The way I've chosen to implement this is that this box rotation only happens if mountain lasers is greater than 7. I do not want there to be any difference from vanilla for the default 7-11 laser settings.
This means that the logic for challenge lasers also has to change based on how many mountain lasers there are. I've implemented that as well.
Tested
Generated some seeds and checked that the spoiler logs make sense, and tested in-game whether lower solutions are now easily solvable