Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorio: fix files from mod base directory not being grabbed correctly in non-apworld #2603

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

When running source form (non-.apworld) on some OS it would not correctly build the arc_path for the files in the base directory, due to trailing /, \ or ., this fixes that.

How was this tested?

By loading the mod into Factorio and seeing if it complains.

If this makes graphical changes, please attach screenshots.

@alwaysintreble alwaysintreble added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Dec 15, 2023
@Berserker66 Berserker66 merged commit 0d929b8 into main Dec 21, 2023
21 checks passed
@Berserker66 Berserker66 deleted the factorio_fix_base_dir_arc_name branch December 21, 2023 03:26
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants