LTTP: Boss Rule Fix #2600
Merged
LTTP: Boss Rule Fix #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 2600 PR 2600 |
Berserker66
approved these changes
Dec 13, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Changes
set_defeat_dungeon_boss_ruleto useadd_ruleso it will not overwrite existing boss rules. I believe this only affects Swamp Palace and could have also been solved by moving the boss rules to the entrance to a new boss room region, as is how other boss room access rules work, are but this fix should be less likely to screw up and break something else.How was this tested?
Generating with Small Key (Swamp Palace) plando'd to the Boss, with and without this fix, and seeing it fail only on this branch.