Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worlds Docs: Translations German (Clique, BK Sudoku, OoT) #2581

Merged
merged 36 commits into from
Jan 16, 2024
Merged

Worlds Docs: Translations German (Clique, BK Sudoku, OoT) #2581

merged 36 commits into from
Jan 16, 2024

Conversation

ZeitHeld
Copy link
Contributor

@ZeitHeld ZeitHeld commented Dec 9, 2023

I still dunno, if that is how you do a PR, but I hope it's good enough

What is this fixing or adding?

3 Games have been translated into german (and even tried to keep the formatting rules). The Setup/Guide as well as the game info page(?) (since it has en_ in front of it)

Additions:

  • BK-Sudoku
  • Clique
  • OoT (With a screenshot)

Only one Screenshot has been added to Ocarina of Time (could be used universally), regarding the Patch Download for ROMS.

@ZeitHeld ZeitHeld requested a review from ThePhar as a code owner December 9, 2023 04:08
@BootsinSoots BootsinSoots mentioned this pull request Dec 9, 2023
Open
55 tasks
@BootsinSoots
Copy link
Contributor

Thank you for your work! You did the PR right, good job. I advertised it a little so those who speak German can provide feedback (I do not speak it myself, so I'm not much help)

@Jarno458
Copy link
Collaborator

Jarno458 commented Dec 9, 2023

Well for BK sudoku with my limited German skiles, it seems alright, but you forgot something important for all 3 games
You need to add the new guides to the game its WebWorld often located in the __init__.py

@Jarno458 Jarno458 added the is: documentation Improvements or additions to documentation. label Dec 9, 2023
@black-sliver
Copy link
Member

Can we finally request a doc review from berserker? :D

@ZeitHeld
Copy link
Contributor Author

ZeitHeld commented Dec 9, 2023

Well for BK sudoku with my limited German skiles, it seems alright, but you forgot something important for all 3 games You need to add the new guides to the game its WebWorld often located in the __init__.py

Ooh, I didn't really read that anywhere (tbh, going through the docs already is a bit obscure and stuff. Not quite obvious).
But I think I can look at it sooner or later if I can add it in by myself (shouldn't be too hard ig?)

@ZeitHeld
Copy link
Contributor Author

ZeitHeld commented Dec 9, 2023

what did that-

uuhhh, anyways, I added the lines of code into the init's and also added some "tranlation flexibility" into some others, that weren't made for multiple setups

Though, I think I made the changes into my "main" branch on accident- lemme fix that

@ZeitHeld ZeitHeld requested a review from Berserker66 as a code owner December 9, 2023 18:56
@ZeitHeld
Copy link
Contributor Author

ZeitHeld commented Dec 9, 2023 •
edited
Loading

Okay I think now it should be added/changed- (sorry about that)
Edit: I did not manually request that view tho- not in person (idk how)

@Jarno458
Copy link
Collaborator

Jarno458 commented Dec 9, 2023 •
edited
Loading

Oke +1 for your enthusiasm, but you refactored a lot of init.py's, this is not ideal as it put them in the scope of your PR and will require those maintainers to approve the PR in addition to the 3 maintainers of the guides you actually edited

@Jarno458
Copy link
Collaborator

Jarno458 commented Dec 9, 2023

While i admire your efforts to translate the game info page, i dont think there is currently any way to open those in a different language so that page will never be shown.. until a link to it is added somewhere

@ZeitHeld
Copy link
Contributor Author

Yeah, the edits were not initially ideal, but made as it is really not a big change- And kost of them are ones I try to translate too

And the info pages, yeaah- I noticed that later on too, but thought it could be done due to them as starting with "en"
If it eventually gets added (possibly along with translated settings pages) they could be used

@black-sliver
Copy link
Member

Please revert the changes to worlds that you didn't intend to modify. This will only create merge conflicts.

@ZeitHeld
Copy link
Contributor Author

Please revert the changes to worlds that you didn't intend to modify. This will only create merge conflicts.

Okay, I think that should all done now
Sorry about the issue with that

black-sliver
black-sliver reviewed Jan 13, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel bad for the amount of suggestions.
German Komma be German Komma. Probably still missed some.

worlds/bk_sudoku/docs/de_Sudoku.md Outdated Show resolved Hide resolved
worlds/bk_sudoku/docs/de_Sudoku.md Outdated Show resolved Hide resolved
worlds/bk_sudoku/docs/de_Sudoku.md Outdated Show resolved Hide resolved
worlds/bk_sudoku/__init__.py Outdated Show resolved Hide resolved
worlds/bk_sudoku/__init__.py Outdated Show resolved Hide resolved
worlds/oot/docs/setup_de.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_de.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_de.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_de.md Outdated Show resolved Hide resolved
worlds/oot/docs/setup_de.md Outdated Show resolved Hide resolved
ZeitHeld and others added 4 commits January 13, 2024 02:58
@ZeitHeld @black-sliver
Sugesstion - Fixes in Grammar (and Typos)
69c61db 
One or two suggesstions need to be changed a bit further (such as an incomplete sentence)

Co-authored-by: black-sliver <[email protected]>
@ZeitHeld @black-sliver
Apply suggestions from code review
d837b3b 
Co-authored-by: black-sliver <[email protected]>
@ZeitHeld @black-sliver
Apply suggestions from code review
a6d0206 
Co-authored-by: black-sliver <[email protected]>
@ZeitHeld
Update guide_de.md
c75aef4
@ZeitHeld
Copy link
Contributor Author

I feel bad for the amount of suggestions. German Komma be German Komma. Probably still missed some.

It's a diffciult langunge with it's forms of politeness, but I think/hope that after this weird sentence everything should be good.
Unless there is another issue found by someone or someone else
Don't worry about the amount. I shouldn't have done them at a late time lmao

@black-sliver
Copy link
Member

but I think/hope that after this weird sentence everything should be good.

This is still to be done, right? (I see two conversations that are not marked as resolved yet.)

@ZeitHeld
Copy link
Contributor Author

Okay, I think that should be done now?
At least it seems to be resolved

black-sliver
black-sliver reviewed Jan 15, 2024
View reviewed changes
worlds/bk_sudoku/__init__.py Outdated Show resolved Hide resolved
worlds/oot/docs/setup_de.md Outdated Show resolved Hide resolved
black-sliver
black-sliver approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. I DM'd phar and espeon to make sure they don't have any objections.

@black-sliver black-sliver merged commit d756960 into ArchipelagoMW:main Jan 16, 2024
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@ZeitHeld @black-sliver @Jouramie
Worlds Docs: Translations German (Clique, BK Sudoku, OoT) (Archipelag…
16d5993 
…oMW#2581)

* Sudoku German

* German OOT (+ Room Image)

* German Clique

* german translation

* translation flexibility - ff1

* german setup - oot

* Transaltion Flexibilty - SM64

* translation flexibilty - factorio

* translation flexibilty - kh2

* translation flexibility - Super Metroid

* translation flexibility - Stardew Valley

* german translation added - clique

* translation flexibility - terraria

* translation flexibilty - checksfinder

* Sudoku Setup - Grammar Fix

* Sudoku Main - Fix Grammar

* Revert "translation flexibility - ff1"

This reverts commit 6df434c.

* Revert "Transaltion Flexibilty - SM64"

This reverts commit 754bf95.

* Revert "translation flexibilty - factorio"

This reverts commit db1226a.

* Revert "translation flexibility - Super Metroid"

This reverts commit ca5bd9a.

* Revert "translation flexibilty - kh2"

This reverts commit 076534e.

* Revert "translation flexibility - Stardew Valley"

This reverts commit 4b13701.

* Revert "translation flexibility - terraria"

This reverts commit a0abfc8.

* Revert "translation flexibilty - checksfinder"

This reverts commit a4de499.

* Sugesstion - Fixes in Grammar (and Typos)

One or two suggesstions need to be changed a bit further (such as an incomplete sentence)

Co-authored-by: black-sliver <[email protected]>

* Apply suggestions from code review

Co-authored-by: black-sliver <[email protected]>

* Apply suggestions from code review

Co-authored-by: black-sliver <[email protected]>

* Update guide_de.md

* Update setup_de.md

* Update de_Sudoku.md

* Update __init__.py

* Update worlds/oot/docs/setup_de.md

Co-authored-by: black-sliver <[email protected]>

---------

Co-authored-by: black-sliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-sliver black-sliver black-sliver approved these changes

@ThePhar ThePhar Awaiting requested review from ThePhar ThePhar is a code owner

@Berserker66 Berserker66 Awaiting requested review from Berserker66

Assignees
No one assigned
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeitHeld @BootsinSoots @Jarno458 @black-sliver