Core: remove start_inventory_from_pool from early_items #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilbert1412
approved these changes
Dec 9, 2023
| @@ -117,6 +117,15 @@ def main(args, seed=None, baked_server_options: Optional[Dict[str, object]] = No | |||
| for item_name, count in world.start_inventory_from_pool.setdefault(player, StartInventoryPool({})).value.items(): | |||
| for _ in range(count): | |||
| world.push_precollected(world.create_item(item_name, player)) | |||
| # remove from_pool items also from early items handling, as starting is plenty early. | |||
There was a problem hiding this comment.
I think this snippet would be way easier to read and understand with slightly improved variable names. For example, "early" is used twice, in mutually exclusive usages (assign, then read, then assign again, then read again), so if it was two variables, making the difference between both usages more clear, it would be a good improvement
ScootyPuffJr1
added
the
affects: core
Berserker66
added
the
is: bug/fix
Berserker66
commented
Dec 10, 2023
Magnemania
pushed a commit
to Magnemania/Archipelago
that referenced
this pull request
Jan 3, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Exhausts start_inventory_from_pool items from early_items as well, which fixes:
How was this tested?
With Subnautica Seaglide Fragments
If this makes graphical changes, please attach screenshots.