-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: set consistent server defaults #2566
Conversation
would this change (specifically the plando part) mean that issue #1943 would finally be resolved? |
fixes #1943 Plando and remaining lgtm. Did we ever get the majority on the auto-collect/release? Or is this a bdfl veto? :D |
There was supposed to be a vote? |
The "external" asyncs i play in always use manual collect/release to avoid spamming (e.g. alttp), so that change may be unexpected for some people. (Vote wouldn't hurt, I guess) In addition to that, if host.yaml already exists, the local behaviour will be different than the webhost behaviour - that is for all existing installations that upgrade. |
And that's why I brought up issue #1943 in my previous comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you want to make a poll for it, should probably put it in the release notes that the default for release/collect has changed.
Oh, I forgot: I still think reversing the roles for release and collect would be the better Alternative than auto-release. |
What is this fixing or adding?
set consistent server defaults
Some reasonings:
In general these should be reasonable defaults someone can just start a game with, and the other options should offer customization from there.
items plando allows modifying of other worlds, the others are world-local. It should therefore be opt in, preferably after the host has read the plando guide to know what to look out for.
Collect and Release on Auto, teaches that the systems exist, can be customized if changes are desired and is a reasonable default; as well as a default encountered in say The Big Async.
Moved Items plando visually up, as it has the biggest impact and support.
How was this tested?
I only tested the webhost changes
If this makes graphical changes, please attach screenshots.