Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Fix logic error with Symmetry Island Upper in doors: panels (broken seed reported) #2565

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Dec 5, 2023

Door entities think they can be solved without any other panels needing to be solved.

Usually, this is true, because they no longer need to be "powered on" by a previous panel.
However, there are some entities that need another entity to be powered/solved for a different reason.
In this case, Symmetry Island Lower Left set opens the latches that block your ability to solve the panel. The panel itself actually starts on. Playing doors: panels does not change this, unlike usually where dependencies like this get removed by playing that mode.

In the long term, I want to somehow be able to "mark" dependencies as "environmental" or "power based" so I can distinguish them properly.

Shortest version ever: Colored Dots can be on Symmetry Island Upper Panel in a doors: panels seed, which creates an unbeatable seed

I also feel a little self-conscious about the amount of PRs I have been opening since the big content/refactor PR got merged.
Rest assured, all these bugs pre-date that big PR, they just haven't been discovered.
Which somehow makes me feel better, idk if it's supposed to. XD

@NewSoupVi NewSoupVi added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Dec 5, 2023
@Berserker66 Berserker66 merged commit 229a263 into ArchipelagoMW:main Dec 6, 2023
12 checks passed
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…els (broken seed reported) (ArchipelagoMW#2565)

Door entities think they can be solved without any other panels needing to be solved.

Usually, this is true, because they no longer need to be "powered on" by a previous panel.
However, there are some entities that need another entity to be powered/solved for a different reason.
In this case, Symmetry Island Lower Left set opens the latches that block your ability to solve the panel. The panel itself actually starts on. Playing doors: panels does not change this, unlike usually where dependencies like this get removed by playing that mode.

In the long term, I want to somehow be able to "mark" dependencies as "environmental" or "power based" so I can distinguish them properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants