Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonClient: request datapackage per-game #2563

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

Berserker66
Copy link
Member

What is this fixing or adding?

Updates the reference clients to request one game's datapackage at a time. While it can handle very large packets and doesn't really need it, it makes it slightly more future proof and might inspire someone to copy it into their library as well.

How was this tested?

By making a client forget it has a cache.

If this makes graphical changes, please attach screenshots.

image

@ThePhar ThePhar added is: refactor/cleanup Improvements to code/output readability or organizization. affects: core Issues/PRs that touch core and may need additional validation. labels Dec 5, 2023
@Jarno458
Copy link
Collaborator

Jarno458 commented Dec 7, 2023

Does this add any benefit?
await self.send_msgs([{"cmd": "GetDataPackage", "games": [game_name]} for game_name in needed_updates])
since its all passed as 1 array to send_msgs, it all still send as part of the same websocket message right?

@Berserker66
Copy link
Member Author

Send as one message, yes. But received as several.

@Berserker66 Berserker66 merged commit f22daca into main Jan 7, 2024
21 checks passed
@Berserker66 Berserker66 deleted the common_client_individual_datapackage branch January 7, 2024 00:42
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants