Pokémon RB: Fix shared connection names + missing connection #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berserker66
reviewed
Dec 2, 2023
| @@ -1944,7 +1945,8 @@ def create_regions(self): | |||
| connect(multiworld, player, region.name, entrance_data["to"]["map"], | |||
| lambda state: logic.rock_tunnel(state, player), one_way=True) | |||
| else: | |||
| connect(multiworld, player, region.name, entrance_data["to"]["map"], one_way=True) | |||
| connect(multiworld, player, region.name, entrance_data["to"]["map"], one_way=True, | |||
| name=entrance_data["name"] if "name" in entrance_data else None) | |||
There was a problem hiding this comment.
Suggested change
| name=entrance_data["name"] if "name" in entrance_data else None) | |
| name=entrance_data.get("name", None)) |
Should be cleaner in the future.
Berserker66
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
How was this tested?
Running generate with some debug code to warn if duplicate entrance names existed.