Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add missing Get location_name_groups_* to network protocol #2550

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

Jarno458
Copy link
Collaborator

@Jarno458 Jarno458 commented Dec 1, 2023

What is this fixing or adding?

The single missing line in the documentation that a user can also _read_ location groups

How was this tested?

tested an _read_location_name_groups_Adventure on the big async and it worked
Viewed the markdown in a browser

@Jarno458 Jarno458 added the is: documentation Improvements or additions to documentation. label Dec 1, 2023
@Jarno458 Jarno458 marked this pull request as ready for review December 1, 2023 23:10
@Jarno458 Jarno458 added the affects: core Issues/PRs that touch core and may need additional validation. label Dec 2, 2023
@Jarno458 Jarno458 changed the title Added undocumented feature Docs: Added undocumented feature Dec 2, 2023
@Jarno458 Jarno458 removed the affects: core Issues/PRs that touch core and may need additional validation. label Dec 2, 2023
Copy link
Contributor

@ReverM ReverM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,
might be worth cleaning up the table (like "Player" and "player") but that's outside the scope of the PR

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@black-sliver black-sliver changed the title Docs: Added undocumented feature Docs: Add missing Get location_name_groups_* to network protocol Dec 28, 2023
@black-sliver black-sliver merged commit d1a17a3 into ArchipelagoMW:main Dec 28, 2023
@Jarno458 Jarno458 deleted the patch-1 branch January 2, 2024 10:57
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants