sm64ex: Refactor Regions and BBH clock fix. #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysintreble
added
the
is: enhancement
N00byKing
force-pushed
the
sm64_arearando_rework
branch
from
1c435b3 to
8065058
Compare
ThePhar
added
is: refactor/cleanup
|
3.8 support isn't projected to be dropped until after two releases from #1933 being merged. Which will most likely be months out to give time for folks to validate. I would recommend changing it unless you're okay with it sitting for a while. |
ThePhar
added
the
is: bug/fix
ThePhar
changed the title
N00byKing
force-pushed
the
sm64_arearando_rework
branch
from
8065058 to
0372e49
Compare
|
Darn, thought it was like next one after RC. |
Berserker66
approved these changes
Dec 6, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Refactors region code to remove references to course index. There were bugs somewhere, but I dont know where tbh. This fixes them but leaves logic otherwise intact, and much cleaner to look at as there's one list less to take care of. Additionally, this fixes stopping the clock from Big Boos Haunt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Refactors region code to remove references to course index.
There were bugs somewhere, but I dont know where tbh.
This fixes them but leaves logic otherwise intact, and much cleaner to look at as there's one list less to take care of.
Additionally, this fixes stopping the clock from Big Boos Haunt.
How was this tested?
Multiple generations, attempting to stop the clock in bbh (also needs client fix, but that one is backwards compatible).
If this makes graphical changes, please attach screenshots.