Hollow Knight: Add additional DeathLink option and add ExtraPlatforms option. #2545
Conversation
ThePhar
added
the
is: enhancement
ThePhar
changed the title
worlds/hk/Options.py
Outdated
|
|
||
|
|
||
| class DeathLinkBreaksFragileCharms(Toggle): | ||
| """Sets if fragile charms break when you are killed by a DeathLink. All other deaths still break fragile charms. |
There was a problem hiding this comment.
As noted by folks on discord it's probably slightly more accurate to say something like "fragile charms will still be broken by your own deaths as usual" to cover for cases where your own deaths actually will not break the charm
There was a problem hiding this comment.
Actually on second thought, maybe removing the "all other deaths still break fragile charms" is better for consistency, or should be implied by the "when you are killed by a deathlink." That would be consistent with the wording on the shade option as well
|
|
||
|
|
||
| class DeathLinkShade(Choice): | ||
| """Sets whether to create a shade when you are killed by a DeathLink and how to handle your existing shade, if any. |
There was a problem hiding this comment.
Similar to the fragile charms setting a caveat that your own deaths will create a shade and remove any existing shade as normal would be good
|
Client side changes are good to go as of ArchipelagoMW-HollowKnight/Archipelago.HollowKnight#203 |
|
Personally, I don't count those as actual deaths anyway if it doesn't drop a shade. E.g. dream fights. |
|
A deathlink is still sent even in cases you normally wouldn't leave a shade or end steel soul. In any case I think the comment regarding shades probably still stands. Maybe the better way to phrase it is to put somewhere that "the penalties of your own deaths inflicted on you are unmodified," either on the deathlink toggle or with respect to each option (e.g. "whether or not a shade spawns from your own deaths is unmodified") |
|
(closing this was unintentional, the mobile UI had it out for me) |
|
Made some more verbiage tweaks. |
What is this fixing or adding?
ArchipelagoMW-HollowKnight/Archipelago.HollowKnight#157 - Splits DeathLink options up to allow more configuration of behavior on death without needing to program all possible combinations in existing DeathLink option.
ArchipelagoMW-HollowKnight/Archipelago.HollowKnight#58 - Also adds an "ExtraPlatforms" option to create additional platforms in Hallownest to make moving around easier.
@BadMagic100 - Leaving in Draft until client-side can be updated and verified they work with these changes.
How was this tested?
No logic changes were made, but verified output on WebHost. Awaiting client-side tests before pulling out of Draft state.
If this makes graphical changes, please attach screenshots.
N/A