Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiServer: Support location name groups in !missing and !checked commands #2538

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Nov 30, 2023

If the second argument of "!missing" or "!checked" is a valid location group, return all missing/checked locations from that group.

This also means adding @mark_raw to _cmd_missing and _cmd_checked, as there are location groups with spaces in them.

Tested:
Tried it with the new location groups in Witness, don't know what else to test

@NewSoupVi NewSoupVi added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 30, 2023
@NewSoupVi
Copy link
Member Author

NewSoupVi commented Nov 30, 2023

To be clear about my personal motivation:

The Witness is introducing "area hints" to audio logs, such as

In the Quarry area, you will find 4 progression items.
2 of them are for other players.

I also added these areas as location groups.

It'd be nice if the player had an easy way to look up all the locations that exist in an area that they just got a hint for so they can use these hints strategically.

I can obviously try to figure out an in-game/in-client UI for this, but I think this is also just a nice feature, that doesn't require a bunch of new stuff, that people will potentially appreciate regardless of game

@PoryGone PoryGone added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Feb 10, 2024
Copy link
Contributor

@Ixrec Ixrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed !checked and !missing now work with my location name groups, even ones with spaces.

Before:
image

After:
image

This is a world where I've already checked almost everything. I also tested on a fresh world with nothing checked, and got the (correctly) opposite results where !checked prints nothing and !missing prints everything.

Code also LGTM.

Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out the changes and tried numerous ways of "breaking" it which all failed. Code LGTM

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Mar 17, 2024
@Berserker66 Berserker66 merged commit 7c44d74 into ArchipelagoMW:main Apr 14, 2024
12 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants