Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KH2: RC1 Bug Fixes #2530

Merged
merged 3 commits into from
Dec 10, 2023

Conversation

JaredWeakStrike
Copy link
Collaborator

@JaredWeakStrike JaredWeakStrike commented Nov 29, 2023

Please format your title with what portion of the project this pull request is
targeting and what it's changing.

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

Changes the finished_game to new variable so now it only checks the game's memory and if it has sent the finished flag before
Fixed ag2 not requiring 1 of each black magic
Fix hitlist if you exclude summon level 7 and have summon levels option turned off

How was this tested?

Put my self into wincon, deleted apsave and restarted the server. Connected and it didnt send out wincon

If this makes graphical changes, please attach screenshots.

@ScootyPuffJr1 ScootyPuffJr1 added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Nov 29, 2023
@JaredWeakStrike JaredWeakStrike changed the title KH2: Client not clearing out finished_game KH2: RC1 Bug Fixes Dec 3, 2023
@ScipioWright ScipioWright added the affects: release/blocker Issues/PRs that must be addressed before next official release. label Dec 7, 2023
@Berserker66 Berserker66 merged commit 6b0eb7d into ArchipelagoMW:main Dec 10, 2023
12 checks passed
@JaredWeakStrike JaredWeakStrike deleted the KH2-refreshclientwin branch December 16, 2023 02:31
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Changes the finished_game to new variable so now it only checks the game's memory and if it has sent the finished flag before
Fixed ag2 not requiring 1 of each black magic
Fix hitlist if you exclude summon level 7 and have summon levels option turned off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: release/blocker Issues/PRs that must be addressed before next official release. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants