The Witness: Fix Logic Error for Keep Pressure Plates 2 EP in puzzle_randomization: none #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…randomization: none Ok this one is a bit involved so stay with me here When EP shuffle was introduced, we had to make certain puzzles remove their symbols after solving them for the first time, because the solvability of related EPs is not guaranteed in Sigma Rando. However, when "puzzle_randomization: None" was introduced, the client added a check for it on whether to remove panel symbols, because it is not necessary if the panels have their vanilla contents - The vanilla panels were made with EP solvability in mind (obviously) HOWEVER. The specific solution to Keep Pressure Plates 2 that allows you to solve Keep Pressure Plates 2 EP requires solving the panel in a particular way that requires the Pressure Plates 2 exit door. Hence, the logic needs to actually change. Right now, it is possible to get "Keep Pressure Plates 2 Exit (Door)" on "Keep Pressure Plates 2 EP" in a "puzzle_randomization: none" seed, which would be unobtainable.
NewSoupVi
added
the
is: bug/fix
Exempt-Medic
approved these changes
Nov 27, 2023
Berserker66
approved these changes
Dec 10, 2023
Magnemania
pushed a commit
to Magnemania/Archipelago
that referenced
this pull request
Jan 3, 2024
…randomization: none (ArchipelagoMW#2515)
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…randomization: none (ArchipelagoMW#2515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok so for being a PR that changes 10 characters, explaining it is actually quite involved, so stay with me here
Some EPs (Environmental Puzzles) require you to use alternate solutions to specific panels that affect the environment.
When EP shuffle was introduced, we had to make certain puzzles remove their symbols after solving them for the first time, because the solvability of related EPs is not guaranteed in Sigma Rando.
However, when "puzzle_randomization: None" was introduced, the client added a check for it on whether to remove panel symbols, because it is not necessary if the panels have their vanilla contents - The vanilla panels were made with EP solvability in mind (obviously)
HOWEVER.
The specific solution to Keep Pressure Plates 2 that allows you to solve Keep Pressure Plates 2 EP requires solving the panel in a particular way that requires the Pressure Plates 2 exit door.
Hence, the logic needs to actually change.
Right now, it is possible to get "Keep Pressure Plates 2 Exit (Door)" on "Keep Pressure Plates 2 EP" in a "puzzle_randomization: none" seed, which would be unobtainable.