Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LttP: remove extra default = False #2497

Merged
merged 2 commits into from
Nov 25, 2023
Merged

LttP: remove extra default = False #2497

merged 2 commits into from
Nov 25, 2023

Conversation

Berserker66
Copy link
Member

@Berserker66 Berserker66 commented Nov 24, 2023

What is this fixing or adding?

removes a line of code.

Not bothering with the initial plan, at least today.

@Berserker66
Copy link
Member Author

Just noticed the sneaky default = False that is there for no reason...

@Berserker66 Berserker66 changed the title LttP: default KDS to on LttP: remove extra default = False Nov 24, 2023
@el-u
Copy link
Collaborator

el-u commented Nov 24, 2023

These changes still don't turn it on by default if that's what you were trying to do.

@Berserker66
Copy link
Member Author

These changes still don't turn it on by default if that's what you were trying to do.

"Not bothering with the initial plan, at least today."

@Berserker66 Berserker66 merged commit edb6200 into main Nov 25, 2023
21 checks passed
@Berserker66 Berserker66 deleted the lttp_default_on_kds branch November 25, 2023 10:12
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants