Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hollow Knight: Don't force mimics local #2482

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

BadMagic100
Copy link
Collaborator

What is this fixing or adding?

Some discussion here https://discord.com/channels/731205301247803413/1176684007061205074

In short there's 5 mimics, them being local or not doesn't really matter at all because there are so few that they're barely meaningful anyway except when it breaks setup in unexpected ways, especially since they can go in shops and such. Plus we have plans to improve the quality of traps in HK anyway ArchipelagoMW-HollowKnight/Archipelago.HollowKnight#20

How was this tested?

It wasn't but I can't see any possible way this would break anything

@BadMagic100 BadMagic100 requested a review from ThePhar as a code owner November 22, 2023 04:27
@BadMagic100 BadMagic100 added the is: enhancement Issues requesting new features or pull requests implementing new features. label Nov 22, 2023
@Joethepic
Copy link
Contributor

Joethepic commented Nov 22, 2023

How do they appear when recieved in game? I believe that was a big reason they were local to begin with because they couldn't be received in a way that made sense.

@BadMagic100
Copy link
Collaborator Author

They are an icon with the mimic screech sound effect. But as I mentioned having mimics be local does not solve this as the exact same behavior is observed if they are randomized into a variety of locations such as shops, dreamers, dream nail, stag tolls, cornifer, etc.

Along that rationale I never really felt that this was a helpful behavior but now I have some decision-making power and an anecdote in which it was actively unhelpful so I'm pulling the trigger to get rid of it. As mentioned there's an open tracking issue to attempt to improve the client side behavior of mimics and add other traps

@ThePhar ThePhar changed the title [HK] Don't force mimics local Hollow Knight: Don't force mimics local Nov 22, 2023
Copy link
Member

@ThePhar ThePhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, worst case while traps are still being figured out and someone wants old behavior they can make them local again.

@ThePhar ThePhar merged commit f959819 into ArchipelagoMW:main Nov 22, 2023
12 checks passed
@BadMagic100 BadMagic100 deleted the patch-3 branch February 11, 2024 06:48
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: enhancement Issues requesting new features or pull requests implementing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants