lufia2ac: fix client behavior at max blue chests combined with party member or capsule monster shuffle #2478
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScootyPuffJr1
added
the
is: bug/fix
Berserker66
approved these changes
Nov 23, 2023
|
You may want to raise minimum client version? |
OK. |
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
…member or capsule monster shuffle (ArchipelagoMW#2478) When option combinations at (or near) the maximum location count were used, the client could trip over a wrongly coded limit and stop sending checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
https://discord.com/channels/731205301247803413/1055241755383046154/1175847379807784981
When option combinations at (or near) the maximum location count were used, the client could trip over a wrongly coded limit and stop sending checks.
How was this tested?
https://discord.com/channels/731205301247803413/1055241755383046154/1175882624745623683