Installer: Add _bizhawk.apworld to installer deleted files
#2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThePhar
changed the title
_bizhawk.apworld to installer deleted files_bizhawk.apworld to installer deleted files
ThePhar
added
the
is: maintenance
ThePhar
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Installer will delete
_bizhawk.apworld, which was in use for versions 0.4.2 and 0.4.3. Unsupported implementations which relied on_bizhawk.apworldshould continue to work with no modification (assuming they followed the examples given), but if_bizhawk.apworldexists, it seems like it's possible that it gets imported over the version that came in the installer (may depend on import order). Whatever the case, it's redundant at best to keep the apworld version around.Progress on creating apworlds out of lib worlds and importing them would make this unnecessary, but until then, I think this line should be included.
How was this tested?
Creating and running an installer to watch it delete the file. Also running the currently released Pokemon Emerald apworld with and without
_bizhawk.apworldto make sure it still worked.