Core: remove duplicate state.item_count #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No deprecation? |
Jarno458
added
is: documentation
black-sliver
approved these changes
Nov 15, 2023
|
want me to wait, or am I good to hit merge? |
|
Shouldn't we wait for other world maintainers? If a generate with 1 of each game works, it should be safe to merge though |
KonoTyran
approved these changes
Nov 16, 2023
silasary
added a commit
to silasary/FFXIVBMB
that referenced
this pull request
Dec 3, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
https://discord.com/channels/731205301247803413/731214280439103580/1174099252713107456
How was this tested?
unittests
If this makes graphical changes, please attach screenshots.