-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Floor and ceil in datastorage #2448
Conversation
Rather than a Then you do the "div" operation and finish with a floor operation as you pass in a list of operations to do in order. Then it can also be useful for other operations that may have float results but we want to remove the decimal somehow. |
That's also an idea, I'm not against it |
Yeah, if we're going to add |
I agree separated floor and ceil operations would be best, just like other operations it can be chained. |
an oddity would be that floor and ceil dont use the operator value, but the same is true for the default operation |
What is this fixing or adding?
Currently it's not doable to divide an integer by another without it becoming a float. This PR adds floor and ceil to the list of possible operations to fix that issue.
I thought about adding an operation to change the type, but that would be either vulnerable to code injection or annoying to do for a niche feature
How was this tested?
I just tested if floor and ceil worked as intended
If this makes graphical changes, please attach screenshots.