Fill: Fix plando removing Usefuls first #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two problems: - A crash in the early "good" item placement on the tutorial gate when a plando contained an item not in the good item list - Crashes when processing malformed plando settings that represent items as nested structures.
…l children are placed early.
ThePhar
added
is: bug/fix
ThePhar
approved these changes
Nov 24, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Co-authored-by: blastron <[email protected]> Co-authored-by: NewSoupVi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fill defines
restitempoolasusefulitempool + filleritempoolwhich is used inremaining_fillwhich itself usesitempool.pop(), but becausepop()defaults to -1, it pops and places the filler items first. This switches the order of the summation so that useful items are placed first instead.How was this tested?
Running generations with plando adding in new items and seeing which items were removed from the pool before and after the change.