DLC Quest Stardew bug

[axe-y]

I fix a bug where I made an item early but it didn't exist so stardew was waiting for the early item to be collected and the generation exploded.
I also finally added get_filler_item_name

ex. "MyGame4: implement new game" or "Docs: add new guide for customizing MyGame3"

What is this fixing or adding?

a generation bug between DLC Quest and Stardew

How was this tested?

ran the yaml that didn't worked before with success

If this makes graphical changes, please attach screenshots.

[el-u]

So we've reached the point where other worlds have to work around Stardew Valley's rogue behavior...

[alwaysintreble]

while this fix works, I disagree with it on a fundamental level.

[Jouramie]

Even tho it's merged already, for a documentation purpose, I want to reinforce that there is no relation to Stardew with this bug (other than the detection of the issue). DLC Quest sets an item early without adding it to the pool, and this should be completely illegal (and tested). I would even expect the generation to always crash because of that. An early item is impossible to collect, the multi world should not even be solvable.

For Stardew, we had to work around a limitation in the core causing all event to be collected in the first sphere, which caused all seasons to be merged altogether; making some seeds literally unplayable. The solution of hooking into early items of other worlds might not be the most elegant (and does not always work if there is no early item in the multi world), but at least it gets the job done, in a creative manner.

[el-u]

Hard disagree.

The only thing that should be illegal here is one world inspecting the parameters of other worlds.