-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: make state.prog_items a Dict[int, Counter[str]]
#2407
Conversation
Stardew Valley overwrites |
I think it's testing that the starting inventory is properly required? But yeah it'd be a lot better to just test that with a clean state instead of telling the state to do things that will never happen in normal circumstances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a generation and connected with ArchipIDLE, so I approve the IDLE change.
Tested it, it does seem to work, and does make debugging simpler |
What is this fixing or adding?
Changes
CollectionState.prog_items
from aCounter[Tuple[str, int]]
to aDict[int, Counter[str]]
, offering more speed.How was this tested?
Generated 1000 world messenger multiworld 10 times before and after and saw a ~9% speed increase. Could use more testing and benchmark numbers, but this should increase generation speed overall.