CommonClient: Add a hints tab #2392
Conversation
ScootyPuffJr1
added
the
is: enhancement
Co-authored-by: el-u <[email protected]>
There was a problem hiding this comment.
Messed around with it for a bit on BizHawkClient and everything seems fine. Nothing in the code really stands out to me as needing changing, but I didn't look too in depth and I'm not familiar with the UI code at all.
Where we're touching the line anyway, replacing single quote strings with double quote strings might be nice.
And a very minor suggestion for the column headers would be to remove the colons, since they already look appropriately like headers anyway.
could the headers maybe be slightly higher point to differentiate them a bit? or a line under them like a traditional table. i think it's fine as is, but that would look a bit nicer. |
There was a problem hiding this comment.
- The cells in a row should be vertically aligned such that the first lines of text of all cells are on the same height.
- When hints are added the line height can become too small and the text overlaps.
- The separator between rows is almost invisible to me (But I guess that's related to the style of CommonClient as a whole and not specific to the Hints tab.)
- One thing I am conflicted about is the Command box being present on the Hints tab. A user might take this to mean that they have to input the !hint command while on this tab; but if they do, they might not notice the server responses such as item name suggestions, because those are printed to a different tab.
kvui.py
Outdated
| 'color': "blue", 'text': hint['entrance'] | ||
| if hint['entrance'] else "Vanilla"})}, | ||
| 'found': {'text': parser.handle_node({'type': "color", 'color': "green" if hint['found'] else "red", | ||
| 'text': "Found" if hint['found'] else "Not Found"})} |
There was a problem hiding this comment.
| 'text': "Found" if hint['found'] else "Not Found"})} | |
| 'text': "found" if hint['found'] else "not found"})} |
(nitpick to be consistent with the network messages)
This was an issue for resizing, definitely a bit mad that it's still showing up for some reason. Kivy will just forget to update when texture_size changes for some reason. |
|
|
I have not completely tested SC2 client (I do not have SC2 downloaded), but I did load it to ensure the hint tab was correctly placed and did not interfere with their additions. I'll need to confirm LADX, but I cannot confirm Wargroove as I do not own it. |
|
Just checked LADX and Wargroove, they looked fine on my machine. |
Co-authored-by: el-u <[email protected]>
Co-authored-by: el-u <[email protected]>
What is this fixing or adding?
Adds a tab to all CommonClient-inherited clients that displays any currently received hints.
How was this tested?
Manually, by use during several Archipelago sessions.
No automated testing was added.
If this makes graphical changes, please attach screenshots.