sm64ex: Replace old launcher tutorial #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The launcher is dead, long live the launcher
ScootyPuffJr1
added
the
is: documentation
Update launcher info for linux support, minor improvements to other sections
N00byKing
changed the title
|
While I'm still giving people time to test, the new launcher is, as far as features are concerned, ready for release. |
ThePhar
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The old launcher was """inherited""" from an existing project aiming to provide a launcher for windows and linux.
Original intention was to improve upon it, and merge everything into upstream, keeping it as generic as possible.
However, upstream abandoned the project not long after, without responding to pull requests.
The launcher additionally had many assumptions built in, and was very unstable. Extending it for new features (such as the patches) was annoying to say the least. There was very little input validation, and users often stumbled on simple issues, causing frustration. Examples include leaving fields empty, use of invalid make flags, exiting the program early due to missing feedback, providing invalid paths and more. While I've fixed some of these issues (Adding
Browse...buttons for folder paths, allowing for special characters in some areas), working with this launcher is also frustrating to me.The new launcher should hopefully remedy these issues by introducing a new and modular base, and check for more issues ahead of the user pressing
Compile. It logs significantly more info to help for debugging, and presents the log to the user during compilation to show that something IS happening, and they aren't just staring at a crashed program.How was this tested?
The new launcher has been tested continuously for about a week during active development, before starting public testing about 4 days ago.
The launcher is not yet feature complete, and bug testing will continue until that is the case.
I've opened this PR to gather feedback on wording, as new functionality is limited to advanced users anyway (Applying Patches).
I'll mark the PR as ready once I am confident that the new launcher will not introduce new issues, and reaches feature parity with the old one.
If this makes graphical changes, please attach screenshots.