Timespinner: Fixed generation error caused by new options system #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarno458
added
the
is: bug/fix
This was referenced Oct 26, 2023
|
This fix will likely not be needed thanks to #2378 |
black-sliver
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Regardless of #2378, this should probably be done in generate early.
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
In the new options system added in #993 the options on the multiworld instance are nolonger available inside the constructor, therefor i had to move my method that calculates logic constrains based on those options to generate_early
If the options do again become available at constructor time, than this can be close
How was this tested?
Many local generations with one or multiple players