Noita: Update to use new Options API #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScipioWright
added
the
is: refactor/cleanup
heinermann
reviewed
Oct 26, 2023
heinermann
suggested changes
Oct 26, 2023
Co-authored-by: Adam Heinermann <[email protected]>
|
You should be able to delete the |
alwaysintreble
suggested changes
Oct 27, 2023
|
Converting to draft until I have the time to fix the merge conflicts and deal with the comments |
# Conflicts: # worlds/noita/Items.py # worlds/noita/Regions.py # worlds/noita/Rules.py
Berserker66
approved these changes
Jan 19, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Reworking the options to make it work with the new options API. Also reworked stuff in several spots to use world: NoitaWorld instead of multiworld: MultiWorld
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Reworking the options to make it work with the new options API.
Also reworked stuff in several spots to use world: NoitaWorld instead of multiworld: MultiWorld
How was this tested?
Generated a few games with different settings, connected it to the mod once
If this makes graphical changes, please attach screenshots.
N/A