SDV: Use the pre-existing cache in location creation #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwaysintreble
changed the title
ThePhar
added
the
is: refactor/cleanup
alwaysintreble
force-pushed
the
fix_sdv
branch
from
0aade46 to
ca95cc1
Compare
agilbert1412
approved these changes
Oct 26, 2023
|
The failures were for a specific branch that berserker is currently working on. This doesn't fix any failures in regards to main but it does offer ~5% speed increase |
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes SDV failures. should also speed it up since it uses the pre-existing cache instead of just pretending it doesn't exist.
How was this tested?
unit tests succeed now.
If this makes graphical changes, please attach screenshots.