Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage: allow loading apworlds from ~/Archipelago and copy scripts #2358

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

AppImage: allow loading apworlds from ~/Archipelago and copy scripts

also fixes some mypy and flake8 violations in worlds/__init__.py

How was this tested?

from worlds.AutoWorld import AutoWorldRegister; AutoWorldRegister.world_types.keys() on py3.9 and py3.11
and [Generate Template Settings] from the AppImage

also fixes some mypy and flake8 violations in worlds/__init__.py
Copy link
Member

@Berserker66 Berserker66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, haven't tested yet.

@black-sliver
Copy link
Member Author

In case nobody has time to test this until the next preview/RC comes out, please just merge as-is.

@ScootyPuffJr1 ScootyPuffJr1 added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. affects: core Issues/PRs that touch core and may need additional validation. labels Oct 25, 2023
@remyjette
Copy link
Collaborator

Worked for me on my steamdeck!

test steps i did:
Checked out this branch, merged in main, built appimage
moved pokemon_emerald.apworld into ~/Archipelago/worlds
Ran the appimage with a.apemerald i had generated elsewhere as an argument Archipelago_0.4.3_linux-x86_64.AppImage path/to/patch.apemerald

It asked for my .gba emerald ROM and path to EmuHawk in a filebrowser window. Path to EmuHawk didn't really work, presumably because it has to run via proton and that opener doesn't know that. Whatever, ran EmuHawk myself, opened the patched ROM, found the lua script in ~/Archipelago/data/lua/connection_bizhawk_generic.lua opened that up, worked great.
Played until I successfully sent an item.

@black-sliver
Copy link
Member Author

Thanks!

@black-sliver black-sliver merged commit d2e9bfb into ArchipelagoMW:main Nov 4, 2023
12 checks passed
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…rchipelagoMW#2358)

also fixes some mypy and flake8 violations in worlds/__init__.py
@black-sliver black-sliver deleted the userpath-apworld branch February 23, 2024 07:29
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…rchipelagoMW#2358)

also fixes some mypy and flake8 violations in worlds/__init__.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: core Issues/PRs that touch core and may need additional validation. is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants