Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Witness: Fix random events not having the correct probabilities #2340

Merged
merged 6 commits into from
Oct 22, 2023

Conversation

NewSoupVi
Copy link
Member

Sigh.
Today I learned that random.randint is inclusive of the upper bound.

Just. Wow

@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 22, 2023
@ThePhar
Copy link
Member

ThePhar commented Oct 22, 2023

Would you prefer to use random.randrange() instead if it makes better sense for you?

@NewSoupVi
Copy link
Member Author

Probably, actually. Let me change it rn

@NewSoupVi
Copy link
Member Author

Nice, a random Secret of Evermore fail.

@Berserker66 Berserker66 merged commit 9f126ad into ArchipelagoMW:main Oct 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants