Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Terraria Setup Guide added information about the Upgraded Research Mod #2338

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

dennisw100
Copy link
Contributor

What is this fixing or adding?

a line to the Upgraded Research Mod that tells people that it can automatically research items to prevent people from reporting the mod not working cause they don't notice the item they received got automatically researched and did therefore not land in their inventory.

How was this tested?

by reading it

If this makes graphical changes, please attach screenshots.

grafik

Added a line to the Upgraded Research Mod that tells people that it can automatically research items to prevent people from reporting the mod not working cause they don't notice the item they received got automatically researched and did therefore not land in their inventory.
@ScootyPuffJr1 ScootyPuffJr1 added the is: documentation Improvements or additions to documentation. label Oct 21, 2023
@@ -31,6 +31,7 @@ highly recommended to use utility mods and features to speed up gameplay, such a
- (Can be used to break progression)
- Reduced Grinding
- Upgraded Research
- (Automatically researchers certain items so don't be afraid when they don't appear in your inventory)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this wording to be awkward. I'd prefer it to be more straightforward and not mention being afraid.

@ThePhar ThePhar requested a review from Seldom-SE October 23, 2023 20:40
@Seldom-SE
Copy link
Collaborator

@ishigh on Discord suggests noting that this mod shouldn't be enabled for non-journey characters. There's a limitation where it still researches certain items for such characters, making the items inaccessible

@dennisw100
Copy link
Contributor Author

dennisw100 commented Oct 26, 2023

well idk haven't played that much around with the mod in non journey mode

Edit: ok I tested and yer that's an issue should I add a line like
"Warning Don't use this mod when your not playing Journey mode it will eat your items"

Dose that work? idk I'm not really all that good at formulating guide sentences

@Seldom-SE
Copy link
Collaborator

How about "(WARNING: Do not use without Journey mode)"

added (WARNING: Do not use without Journey mode)"
@dennisw100
Copy link
Contributor Author

How about "(WARNING: Do not use without Journey mode)"

like the commit I did?

@Seldom-SE
Copy link
Collaborator

Yeah 👍

@ThePhar ThePhar merged commit f701b81 into ArchipelagoMW:main Nov 1, 2023
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants