Muse Dash: Make which .net to download more explicit in setup guides. #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeamonHunter
changed the title
Jarno458
reviewed
Oct 19, 2023
worlds/musedash/docs/setup_en.md
Outdated
| @@ -11,7 +11,7 @@ | |||
| - \[Optional\] [Just as Planned] DLC: [Also Available on Steam](https://store.steampowered.com/app/1055810/Muse_Dash__Just_as_planned/) | |||
| - Melon Loader: [GitHub](https://github.com/LavaGang/MelonLoader/releases/latest) | |||
| - .Net Framework 4.8 may be needed for the installer: [Download](https://dotnet.microsoft.com/en-us/download/dotnet-framework/net48) | |||
| - .Net 6.0 (If not already installed): [Download](https://dotnet.microsoft.com/en-us/download/dotnet/6.0#runtime-6.0.15) | |||
| - .NET Desktop Runtime 6.0.XX (If not already installed): [Download](https://dotnet.microsoft.com/en-us/download/dotnet/6.0#runtime-6.0.15) | |||
There was a problem hiding this comment.
Are you sure you want to hard pin this to version 6.0.15? i would expect it to just be latest version
There was a problem hiding this comment.
Ah. I forgot about that, because it just ignores it anyway. Fixed.
ScootyPuffJr1
added
the
is: documentation
|
Spanish part is ok, thanks for letting me know. I'd maybe link the spanish page instead (https://dotnet.microsoft.com/es-es/download/dotnet/6.0) for convenience, but that's it. I really didn't think of it when I first translated the guide. |
|
Good call on the spanish links. Both links updated to the spanish pages. Also took the chance to update the [Just as Planned] links to the [Muse Plus] links now that [Just as Planned] is no longer buyable. |
ThePhar
approved these changes
Oct 23, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
The .net 6.0 downloads page has a lot of downloads which can make it a bit difficult to determine which to download. The guide now explicitly references one of them.
How was this tested?
Not Tested. Docs change.
Paging @ShinyNT to double check the spanish translation.