WebHost: Expose name groups through the weighted-settings UI #2327
Conversation
ThePhar
added
is: enhancement
|
So you manually created a group in the Dark Souls 3 |
|
Maybe I'm missing something. I've checked out your branch and confirmed the Dark Souls 3 item group exists in the branch in the world file, but the item group does not appear in my weighted-options page.
|
|
That's so odd! I see it right here, running against an unmodified checkout of this commit:
I wonder if it's some kind of merge issue? Let me try merging the latest |
The request for the JSON file that provides the setting data was missed during the rename in ArchipelagoMW#2037, so prior to this the weighted settings page wasn't rendering at all.
|
Well, it looks like the latest |
…lagoMW#2327) * Factor out a common function for building lists * Expose name groups through the weighted-settings UI * Fix weighted-settings page The request for the JSON file that provides the setting data was missed during the rename in ArchipelagoMW#2037, so prior to this the weighted settings page wasn't rendering at all.
…lagoMW#2327) * Factor out a common function for building lists * Expose name groups through the weighted-settings UI * Fix weighted-settings page The request for the JSON file that provides the setting data was missed during the rename in ArchipelagoMW#2037, so prior to this the weighted settings page wasn't rendering at all.
What is this fixing or adding?
It's already possible for worlds to define
location_name_groupsanditem_name_groupsthat users can use in their YAML files anywherethat takes a location or item list, respectively. This PR exposes this
capability in the web UI as well, including the name groups as a
separate section at the beginning of item and location lists.
How was this tested?
Manually tested by defining groups in the Dark Souls III world,
generating YAML files, and so on.
If this makes graphical changes, please attach screenshots.