Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hylics 2: Various fixes and APWorld support #2324

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Hylics 2: Various fixes and APWorld support #2324

merged 9 commits into from
Oct 18, 2023

Conversation

TRPG0
Copy link
Collaborator

@TRPG0 TRPG0 commented Oct 18, 2023

  • Fix generation failing with certain gesture shuffle options
    • Fixed passing ItemDict to multidata instead of item code
    • Don't allow CHARGE UP to be placed at Foglast: TV
  • APWorld support by removing LogicMixin from Rules.py

@ThePhar ThePhar added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Oct 18, 2023
@ThePhar ThePhar changed the title Hylics 2: Various fixes Hylics 2: Various fixes and APWorld support Oct 18, 2023
@ThePhar ThePhar added the is: refactor/cleanup Improvements to code/output readability or organizization. label Oct 18, 2023
@Berserker66 Berserker66 merged commit 11ebc52 into ArchipelagoMW:main Oct 18, 2023
14 checks passed
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
@TRPG0 @FlySniper
Hylics 2: Various fixes and APWorld support (ArchipelagoMW#2324)
955e9ec 
- Fix generation failing with certain gesture shuffle options
    - Fixed passing ItemDict to multidata instead of item code
    - Don't allow CHARGE UP to be placed at Foglast: TV
- APWorld support by removing LogicMixin from Rules.py
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
@TRPG0 @Jouramie
Hylics 2: Various fixes and APWorld support (ArchipelagoMW#2324)
17c745c 
- Fix generation failing with certain gesture shuffle options
    - Fixed passing ItemDict to multidata instead of item code
    - Don't allow CHARGE UP to be placed at Foglast: TV
- APWorld support by removing LogicMixin from Rules.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: refactor/cleanup Improvements to code/output readability or organizization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TRPG0 @Berserker66 @ThePhar