Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added Note Explaining BK and fix typo in advanced settings #2316

Merged

Conversation

BootsinSoots
Copy link
Contributor

What is this fixing or adding?

Added suggested change regarding BK mode from Issue #2295

How was this tested?

Previewed changes in viewer to make sure PEP8 followed and looks correct

Added suggested change regarding BK mode from Issue ArchipelagoMW#2295
@alwaysintreble
Copy link
Collaborator

this is already in the glossary. if you think it's relevant here add a hyperlink instead of duplicating text

Copy link
Contributor

@ReverM ReverM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link has been added, typo fixed. Can be merged

@ScootyPuffJr1 ScootyPuffJr1 added the is: documentation Improvements or additions to documentation. label Oct 17, 2023
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@black-sliver black-sliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@black-sliver black-sliver changed the title Docs: Added Note Explaining BK Docs: Added Note Explaining BK and fix typo in advanced settings Oct 22, 2023
@black-sliver black-sliver merged commit 5024434 into ArchipelagoMW:main Oct 22, 2023
7 checks passed
@BootsinSoots BootsinSoots deleted the advanced_settings_update branch October 22, 2023 12:32
FlySniper pushed a commit to FlySniper/Archipelago that referenced this pull request Nov 14, 2023
…hipelagoMW#2316)

* Added Note Explaining BK

Added suggested change regarding BK mode from Issue ArchipelagoMW#2295

* Changed to Glossary hyperlink

* Fix minor typo in exclude_locations

* Update worlds/generic/docs/advanced_settings_en.md

Co-authored-by: kindasneaki <[email protected]>

* Docs: Reformat advanced_settings_en/progression_balancing

---------

Co-authored-by: kindasneaki <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Jouramie pushed a commit to Jouramie/Archipelago that referenced this pull request Feb 28, 2024
…hipelagoMW#2316)

* Added Note Explaining BK

Added suggested change regarding BK mode from Issue ArchipelagoMW#2295

* Changed to Glossary hyperlink

* Fix minor typo in exclude_locations

* Update worlds/generic/docs/advanced_settings_en.md

Co-authored-by: kindasneaki <[email protected]>

* Docs: Reformat advanced_settings_en/progression_balancing

---------

Co-authored-by: kindasneaki <[email protected]>
Co-authored-by: black-sliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants