-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS3: Modified theme and warning color in docs for accessibility #2312
Merged
black-sliver
merged 7 commits into
ArchipelagoMW:main
from
nicholassaylor:ds2-accessibility
Feb 29, 2024
Merged
DS3: Modified theme and warning color in docs for accessibility #2312
black-sliver
merged 7 commits into
ArchipelagoMW:main
from
nicholassaylor:ds2-accessibility
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
ScootyPuffJr1
added
the
is: documentation
Improvements or additions to documentation.
label
Oct 17, 2023
ThePhar
changed the title
DS3, Docs: Modified theme and warning color for accessibility
DS3: Modified theme and warning color in docs for accessibility
Nov 7, 2023
Exempt-Medic
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, new colors are much more accessible
ScipioWright
added
the
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
label
Feb 16, 2024
ThePhar
added
waiting-on: world-maintainer
Issue/PR is waiting for feedback or approval by the maintainer of a world.
and removed
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
labels
Feb 20, 2024
Marechal-L
approved these changes
Feb 21, 2024
ScipioWright
added
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
and removed
waiting-on: world-maintainer
Issue/PR is waiting for feedback or approval by the maintainer of a world.
labels
Feb 21, 2024
github-actions
bot
removed
the
is: documentation
Improvements or additions to documentation.
label
Feb 21, 2024
black-sliver
approved these changes
Feb 29, 2024
github-actions
bot
removed
the
waiting-on: core-review
Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
label
Feb 29, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
TheLX5
pushed a commit
to TheLX5/Archipelago
that referenced
this pull request
Mar 2, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
EmilyV99
pushed a commit
to EmilyV99/Archipelago
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
As mentioned in #2295 , the setup guide for DS3 contained text that was near-impossible for those with protanopia to read. After debating how to best addres sthis issue, I decided that changing the web theme for DS3 was the best course of action since it fit the theme of the game closest and caused the least confusion.
How was this tested?
Ran webhost, viewed changes in various filters designed to mimic types of colorblindness
If this makes graphical changes, please attach screenshots.
Game page
Set-up guide (changes were mirrored in the French guide)