Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS3: Modified theme and warning color in docs for accessibility #2312

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

nicholassaylor
Copy link
Contributor

What is this fixing or adding?

As mentioned in #2295 , the setup guide for DS3 contained text that was near-impossible for those with protanopia to read. After debating how to best addres sthis issue, I decided that changing the web theme for DS3 was the best course of action since it fit the theme of the game closest and caused the least confusion.

How was this tested?

Ran webhost, viewed changes in various filters designed to mimic types of colorblindness

If this makes graphical changes, please attach screenshots.

image
Game page

image
Set-up guide (changes were mirrored in the French guide)

@ScootyPuffJr1 ScootyPuffJr1 added the is: documentation Improvements or additions to documentation. label Oct 17, 2023
@ThePhar ThePhar changed the title DS3, Docs: Modified theme and warning color for accessibility DS3: Modified theme and warning color in docs for accessibility Nov 7, 2023
@ThePhar ThePhar requested a review from Marechal-L November 7, 2023 18:50
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, new colors are much more accessible

@ScipioWright ScipioWright added the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 16, 2024
@ThePhar ThePhar added waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Feb 20, 2024
@ScipioWright ScipioWright added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Feb 21, 2024
@github-actions github-actions bot removed the is: documentation Improvements or additions to documentation. label Feb 21, 2024
@black-sliver black-sliver merged commit 7ebd5d3 into ArchipelagoMW:main Feb 29, 2024
15 checks passed
@github-actions github-actions bot removed the waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. label Feb 29, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
TheLX5 pushed a commit to TheLX5/Archipelago that referenced this pull request Mar 2, 2024
@nicholassaylor nicholassaylor deleted the ds2-accessibility branch March 4, 2024 02:43
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants