Ocarina of Time: Increase function cache size for reading JSON data #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed optional maxsize parameter, setting it to the default of 128.
|
@espeon65536 For your visibility. |
ScootyPuffJr1
added
the
is: refactor/cleanup
|
I have no idea why I left a cap on the cache when MQ was introduced. Looks fine to me. |
Berserker66
approved these changes
Oct 18, 2023
FlySniper
pushed a commit
to FlySniper/Archipelago
that referenced
this pull request
Nov 14, 2023
Removed optional maxsize parameter, setting it to the default of 128.
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Removed optional maxsize parameter, setting it to the default of 128.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ocarina of Time uses
lru_cache()for caching JSON data being read for logic and hints with amaxsizeof 13.While there are 12 dungeon files and an overworld file, there are also Master Quest dungeons, glitched logic, etc. to cache as well.
For now, I removed the optional
maxsizeparameter, setting it to the default of 128.From testing these changes on a multiworld with 9 OoT players, using various combinations of Glitchless, Glitchless MQ, and Glitched logic, the total files reads was brought from 126 to 40.