-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add Spanish guide for Muse Dash #2297
Conversation
referencing setup_es on init.py
fixing a space
hopefully I edited the init.py code correctly (I did basically the same that I did with pokemon rb guide but just in case) as a small note on the translation's side, not sure if whatever that throws the "No Support Module Loaded" error translates it to spanish if the system is set to, so leaving that part untraslated for now (of course it can be changed in the future is so) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python code looks good! Ran it locally under WebHost and the guide appears as expected.
Concerning the "No Support Module Loaded" issue, I believe that as long as the mod does not provide the translation, then it is good to remain as is. If there is a Spanish translation for the mod, then I believe that having the section titled "No Support Module Loaded / " or something similar would be preferable since a Spanish speaker could find themselves in the English translation either way.
No comment on the translation side of the rest of the guide.
yeah, since neither the game (muse dash) nor melon loader (the mod client) are translated I assumed the error wouldn't be translated (I never stumbled into this error myself either), but sometimes there's generic windows messages that get translated to the local language even if the software source isn't, so I wasn't sure myself thanks for commenting once again! very appreciated |
A quick google translate of the content reveals no skullduggery is afoot. |
Just chiming in to confirm that yes the error should still be Thanks for creating the guide! |
yay, thank you for the confirmation, and no problem! |
* adding setup_es * Update setup_es.md * Update setup_es.md * Update __init__.py referencing setup_es on init.py * Update __init__.py fixing a space
* adding setup_es * Update setup_es.md * Update setup_es.md * Update __init__.py referencing setup_es on init.py * Update __init__.py fixing a space
What is this fixing or adding?
This adds a spanish guide for Muse Dash, based off the current (from main) english guide.
How was this tested?
By me, proofreading a couple of times.